Remove automatic from TunnelQuantumResistance#10057
Conversation
|
🚨 End to end tests failed. Please check the failed workflow run. |
07af83c to
1e4897c
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 15 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on mojganii).
ios/MullvadSettings/QuantumResistanceSettings.swift line 39 at r1 (raw file):
} public func encode(to encoder: Encoder) throws {
We don't need the encoder here, right?
ios/MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift line 341 at r1 (raw file):
/// after upgrading to versions where `automatic` no longer exists. func testTunnelQuantumResistanceMigratesAutomaticToOn() throws {
Nit: Remove empty line.
mojganii
left a comment
There was a problem hiding this comment.
@mojganii made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on rablador).
ios/MullvadSettings/QuantumResistanceSettings.swift line 39 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
We don't need the encoder here, right?
Since we use CodingKeys we need it. one way is the key with strings but it's not great.
1e4897c to
64a7662
Compare
mojganii
left a comment
There was a problem hiding this comment.
@mojganii made 1 comment and resolved 1 discussion.
Reviewable status: 14 of 15 files reviewed, 1 unresolved discussion (waiting on rablador).
ios/MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift line 341 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Nit: Remove empty line.
Done
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved.
64a7662 to
467622f
Compare
This PR removes the
.automaticoption from Quantum Resistance and falls back to .on for existing users.This change is