Skip to content

Remove automatic from TunnelQuantumResistance#10057

Merged
pinkisemils merged 1 commit intomainfrom
remove-automatic-quantum-resistant-tunnel-option-ios-1361
Mar 25, 2026
Merged

Remove automatic from TunnelQuantumResistance#10057
pinkisemils merged 1 commit intomainfrom
remove-automatic-quantum-resistant-tunnel-option-ios-1361

Conversation

@mojganii
Copy link
Copy Markdown
Contributor

@mojganii mojganii commented Mar 23, 2026

This PR removes the .automatic option from Quantum Resistance and falls back to .on for existing users.


This change is Reviewable

@mojganii mojganii self-assigned this Mar 23, 2026
@mojganii mojganii added the iOS Issues related to iOS label Mar 23, 2026
@linear
Copy link
Copy Markdown

linear bot commented Mar 23, 2026

@github-actions
Copy link
Copy Markdown

🚨 End to end tests failed. Please check the failed workflow run.

@mojganii mojganii force-pushed the remove-automatic-quantum-resistant-tunnel-option-ios-1361 branch from 07af83c to 1e4897c Compare March 24, 2026 08:54
@mojganii mojganii requested a review from rablador March 24, 2026 08:54
Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 15 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on mojganii).


ios/MullvadSettings/QuantumResistanceSettings.swift line 39 at r1 (raw file):

    }

    public func encode(to encoder: Encoder) throws {

We don't need the encoder here, right?


ios/MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift line 341 at r1 (raw file):

    /// after upgrading to versions where `automatic` no longer exists.
    func testTunnelQuantumResistanceMigratesAutomaticToOn() throws {

Nit: Remove empty line.

Copy link
Copy Markdown
Contributor Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mojganii made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on rablador).


ios/MullvadSettings/QuantumResistanceSettings.swift line 39 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

We don't need the encoder here, right?

Since we use CodingKeys we need it. one way is the key with strings but it's not great.

@mojganii mojganii force-pushed the remove-automatic-quantum-resistant-tunnel-option-ios-1361 branch from 1e4897c to 64a7662 Compare March 24, 2026 13:04
Copy link
Copy Markdown
Contributor Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mojganii made 1 comment and resolved 1 discussion.
Reviewable status: 14 of 15 files reviewed, 1 unresolved discussion (waiting on rablador).


ios/MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift line 341 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: Remove empty line.

Done

Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@mojganii mojganii force-pushed the remove-automatic-quantum-resistant-tunnel-option-ios-1361 branch from 64a7662 to 467622f Compare March 25, 2026 08:19
@pinkisemils pinkisemils merged commit 5552329 into main Mar 25, 2026
16 checks passed
@pinkisemils pinkisemils deleted the remove-automatic-quantum-resistant-tunnel-option-ios-1361 branch March 25, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants